Remove Jackson from AWS Helper class#247
Merged
Merged
Conversation
realark
force-pushed
the
ark/remove_jackson_from_aws_helper
branch
from
acb85a4 to
1f011d5
Compare
realark
force-pushed
the
ark/remove_jackson_from_aws_helper
branch
from
1f011d5 to
624bee3
Compare
realark
force-pushed
the
ark/remove_jackson_from_aws_helper
branch
from
624bee3 to
b2af749
Compare
palazzem
approved these changes
Mar 2, 2018
realark
force-pushed
the
ark/remove_jackson_from_aws_helper
branch
4 times, most recently
from
7b0b625 to
b2af749
Compare
Contributor
|
Why was Jackson on the class path at all? |
Contributor
Author
|
It was being used as a one-liner to parse the aws request headers into a string for the |
Contributor
|
No, I understand that. I’m wondering how the dependency got onto the classpath. Is it a transitive dependency from AWS? |
Contributor
Author
|
Yep, looks like it's a transitive dependency from aws. Our shadow rules renamed it to the datadog prefix, then the recent classloader overhaul made those datadog deps unreachable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referencing core agent classes in helper classes can lead to class load exceptions because those classes won't always be available on the classloader the helper is injected on.